[4.0] close collapse when opening a dropdown#43891
Merged
laoneo merged 5 commits intojoomla:4.4-devfrom Aug 9, 2024
hans2103:feature/close-collapse-when-opening-dropdown
Merged
[4.0] close collapse when opening a dropdown#43891laoneo merged 5 commits intojoomla:4.4-devfrom hans2103:feature/close-collapse-when-opening-dropdown
laoneo merged 5 commits intojoomla:4.4-devfrom
hans2103:feature/close-collapse-when-opening-dropdown
Conversation
joomla-cms-bot
added
NPM Resource Changed
Contributor
|
I have tested this item ✅ successfully on 3d7b7df This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43891. |
Member
|
@hans2103 Please fix the javascript cs issues reported here https://ci.joomla.org/joomla/joomla-cms/77860/1/33 : |
Contributor
Author
|
@richard67 lint:js issue have been fixed |
brianteeman
reviewed
Aug 7, 2024
build/media_source/templates/administrator/atum/js/template.es6.js
Outdated
Show resolved
Hide resolved
…6.js Co-authored-by: Brian Teeman <brian@teeman.net>
Contributor
|
I have tested this item ✅ successfully on c3a925f This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43891. |
|
I have tested this item ✅ successfully on c3a925f ( Thanks for this fix, I sometimes have to use my mobile phone and this will help! ) This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43891. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43891. |
Member
|
Thanks! |
dgrammatiko
pushed a commit
to dgrammatiko/joomla-cms
that referenced
this pull request
Aug 11, 2024
* make sure you click on the button, not any of the children * close collapse when click to open a dropdown * fix lint:js issues * Update build/media_source/templates/administrator/atum/js/template.es6.js Co-authored-by: Brian Teeman <brian@teeman.net> --------- Co-authored-by: Brian Teeman <brian@teeman.net>
dgrammatiko
pushed a commit
to dgrammatiko/joomla-cms
that referenced
this pull request
Aug 11, 2024
* make sure you click on the button, not any of the children * close collapse when click to open a dropdown * fix lint:js issues * Update build/media_source/templates/administrator/atum/js/template.es6.js Co-authored-by: Brian Teeman <brian@teeman.net> --------- Co-authored-by: Brian Teeman <brian@teeman.net>
Contributor
|
Given that accordions are also using data-bs-toggle="collapse" it also causes all accordions tabs to close. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43891. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #28952 .
Summary of Changes
This PR will add some javascript.
When you click on a dropdown element (data-bs-toggle="dropdown") , all open collapse elements (data-bs-toggle="collapse") will close
Testing Instructions
npm cito compile both css and jsActual result BEFORE applying this Pull Request
Screen.Recording.2024-08-07.at.11.10.00.mov
Expected result AFTER applying this Pull Request
Screen.Recording.2024-08-07.at.11.44.36.mov
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed